Skip to content

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Bump the version to v1.28.2

Which issue(s) this PR fixes:

Refers to #7411

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 24, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #7428 (11e6a72) into release-1.28 (d3d1f84) will not change coverage.
Report is 9 commits behind head on release-1.28.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.28    #7428   +/-   ##
=============================================
  Coverage         49.26%   49.26%           
=============================================
  Files               136      136           
  Lines             15601    15601           
=============================================
  Hits               7686     7686           
  Misses             7006     7006           
  Partials            909      909           

@haircommander
Copy link
Member

in my ideal we'd get 1.28 version of #7408 in here first

@saschagrunert
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2023
@kwilczynski
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

@haircommander do we want to move forward with this PR?

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@haircommander
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2023
@openshift-ci openshift-ci bot merged commit e7be4e1 into cri-o:release-1.28 Nov 1, 2023
@saschagrunert saschagrunert deleted the release-1.28-version branch November 2, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants