Skip to content

Conversation

@haircommander
Copy link
Member

Signed-off-by: Peter Hunt~ [email protected]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. labels Dec 22, 2022
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl December 22, 2022 21:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #6470 (7705f99) into main (c25920c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6470   +/-   ##
=======================================
  Coverage   42.51%   42.52%           
=======================================
  Files         126      126           
  Lines       14942    14942           
=======================================
+ Hits         6353     6354    +1     
+ Misses       7899     7898    -1     
  Partials      690      690           

Because I am unable to figure out how to make it work with 1.0.0

Signed-off-by: Peter Hunt~ <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Member Author

due to cri-o/ocicni#77 I had to add d06cae7 . I would like to figure out a way to work around it after the holiday

@openshift-ci-robot
Copy link

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/kata-jenkins 7705f99 link true /test kata-containers
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

/test ci-crun-e2e

1 similar comment
@haircommander
Copy link
Member Author

/test ci-crun-e2e

@haircommander haircommander added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2022
@haircommander
Copy link
Member Author

/override ci/kata-jenkins
/override ci/prow/ci-crun-e2e
/override ci/prow/ci-e2e-conmonrs
/override ci/prow/ci-rhel-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/kata-jenkins, ci/prow/ci-crun-e2e, ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration

Details

In response to this:

/override ci/kata-jenkins
/override ci/prow/ci-crun-e2e
/override ci/prow/ci-e2e-conmonrs
/override ci/prow/ci-rhel-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 214b773 into cri-o:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants