Skip to content

Bump GRPC to v1.27.0 #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 17, 2020
Merged

Bump GRPC to v1.27.0 #4191

openshift-merge-robot merged 1 commit into from
Sep 17, 2020

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 14, 2020 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This fixes the build of the release-note tool, which previously failed
with:

vendor/google.golang.org/api/internal/conn_pool.go:29:2: undefined: grpc.ClientConnInterface

Which issue(s) this PR fixes:

Refers to 15aa81b
Forward-port of #4190

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 14, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #4191 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4191   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files         111      111           
  Lines        9614     9614           
=======================================
  Hits         3934     3934           
  Misses       5301     5301           
  Partials      379      379

@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 14, 2020

/retest

2 similar comments
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 14, 2020

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 14, 2020

/retest

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 14, 2020

LGTM
assuming happy tests

@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 14, 2020

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 14, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Sep 14, 2020

@fidencio Can you check that this keeps kata happy?

@fidencio
Copy link
Contributor

fidencio commented Sep 14, 2020

Sure, gimme an hour or two and I'll get to this.

@fidencio
Copy link
Contributor

fidencio commented Sep 14, 2020

@mrunalp, @saschagrunert,

I've just tested this and it doesn't break anything on kata. Based on this ...
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 14, 2020

Thank you @fidencio ❤️
/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 15, 2020

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 15, 2020

/retest

@mrunalp
Copy link
Member

mrunalp commented Sep 16, 2020

Rebase needed for test fixes

@saschagrunert
Bump GRPC to v1.27.0
0d878de 
This fixes the build of the release-note tool, which previously failed
with:

```
vendor/google.golang.org/api/internal/conn_pool.go:29:2: undefined: grpc.ClientConnInterface
```

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 17, 2020

Rebased on top of the latest master branch.

@fidencio
Copy link
Contributor

fidencio commented Sep 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@fidencio
Copy link
Contributor

fidencio commented Sep 17, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0cb20f4 into cri-o:master Sep 17, 2020
@saschagrunert saschagrunert deleted the grpc branch September 17, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@nalind nalind Awaiting requested review from nalind

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@fidencio fidencio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @TomSweeneyRedHat @openshift-ci-robot @mrunalp @fidencio @openshift-merge-robot