Skip to content

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Nov 1, 2019

Signed-off-by: Mrunal Patel <[email protected]>
@mrunalp mrunalp requested a review from runcom as a code owner November 1, 2019 19:15
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 1, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2019
@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Nov 1, 2019
@haircommander
Copy link
Member

/hold
waiting on #2922

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 1, 2019
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #2939 into release-1.16 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.16    #2939   +/-   ##
=============================================
  Coverage         52.69%   52.69%           
=============================================
  Files                86       86           
  Lines              7268     7268           
=============================================
  Hits               3830     3830           
  Misses             3054     3054           
  Partials            384      384

@haircommander
Copy link
Member

/retest

@mrunalp
Copy link
Member Author

mrunalp commented Nov 1, 2019

/test integration_rhel

@saschagrunert
Copy link
Member

/retest

Yay! 🥳🎉

@Itxaka
Copy link

Itxaka commented Nov 5, 2019

@haircommander #2922 is now merged, should the hold be removed from here? :D

@haircommander
Copy link
Member

@haircommander #2922 is now merged, should the hold be removed from here? :D

Yup 😃
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2019
@saschagrunert
Copy link
Member

/test e2e_fedora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants