Skip to content

[release-1.0] container_create: sort mounts before adding them to the spec #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

[release-1.0] container_create: sort mounts before adding them to the spec #1089

merged 1 commit into from
Oct 30, 2017

Conversation

@runcom
Copy link
Member

@runcom runcom commented Oct 29, 2017

Same as #1087 but for 1.0.x

Signed-off-by: Antonio Murdaca [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2017
@runcom
Copy link
Member Author

runcom commented Oct 29, 2017

/test all

@runcom runcom added this to the v1.0.2 milestone Oct 29, 2017
@runcom
Copy link
Member Author

runcom commented Oct 29, 2017

@mrunalp PTAL

@runcom
Copy link
Member Author

runcom commented Oct 29, 2017

/test all

@runcom
Copy link
Member Author

runcom commented Oct 29, 2017

/test all

@mrunalp
Copy link
Member

mrunalp commented Oct 30, 2017

LGTM @rhatdan PTAL

@rhatdan
Copy link
Contributor

rhatdan commented Oct 30, 2017

LGTM, passes tests. merging.

@rhatdan rhatdan merged commit 29186a6 into cri-o:release-1.0 Oct 30, 2017
@runcom runcom deleted the sort-mounts-v1 branch October 30, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@runcom @mrunalp @rhatdan @k8s-ci-robot