Skip to content

test: Test for OOM condition in a loop #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2017
Merged

test: Test for OOM condition in a loop #1055

merged 1 commit into from
Oct 24, 2017

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Oct 23, 2017

Signed-off-by: Mrunal Patel [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2017
@mrunalp
Copy link
Member Author

mrunalp commented Oct 23, 2017

/test all

@mrunalp
Copy link
Member Author

mrunalp commented Oct 24, 2017

/test integration_rhel

@rhatdan
Copy link
Contributor

rhatdan commented Oct 24, 2017

oom is still failing. :^(

@runcom
Copy link
Member

runcom commented Oct 24, 2017

It passed in #1054

@runcom
Copy link
Member

runcom commented Oct 24, 2017

/test integration_rhel

@TomSweeneyRedHat
Copy link
Contributor

With happy tests, LGTM

@mrunalp
Copy link
Member Author

mrunalp commented Oct 24, 2017

@stevekuznetsov Did we by any chance either change the base of RHEL ami or change the type of instances that we run the tests on? Reason for asking is that OOM test is not completing in even 10 minutes when it used to 100 seconds last tim e we bumped up the timeout for it.

@stevekuznetsov
Copy link
Contributor

The size of the instances has not changed. The AMI jobs are here: https://ci.openshift.redhat.com/jenkins/job/ami_build_origin_int_rhel_crio/

Can you constrain how much memory is available using cgroups or similar so you don't worry about what system you're running on?

@rhatdan
Copy link
Contributor

rhatdan commented Oct 24, 2017

Is this problem caused by the swap patch that @cevich added? And we are just swapping?

@mrunalp
Copy link
Member Author

mrunalp commented Oct 24, 2017

@rhatdan Let me look into that. That could explain this.

@mrunalp
Copy link
Member Author

mrunalp commented Oct 24, 2017

@rhatdan Created #1058 to check.

@mrunalp
Copy link
Member Author

mrunalp commented Oct 24, 2017

/test all

@mrunalp
Copy link
Member Author

mrunalp commented Oct 24, 2017

/test integration_rhel

@runcom runcom merged commit 0385463 into cri-o:release-1.0 Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mrunalp @rhatdan @runcom @TomSweeneyRedHat @stevekuznetsov @k8s-ci-robot