We need to release the SELinux label when we destroy the sandbox #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
|
/test integration_rhel |
|
/retest |
|
/retest |
|
@mrunalp Ooom killer is blowing up on this, I don't see how my PR is related. Any ideas? |
|
Not related, other PRs are failing with that on RHEL |
|
/test integration_rhel |
|
Let's hold on merging this. @runcom is making PRs for his proposed patches. Thanks! |
This will release the MCS Label to be used again. Only do this if we don't have another sandbox using the same label. Also vendor in the latest selinux go bindings, which fixes a leak and properly reserves the SELinux label we are going to use. Signed-off-by: Daniel J Walsh <[email protected]> Signed-off-by: Daniel J Walsh <[email protected]>
|
/test all |
|
Yeah we can get this in if it passes the tests. |
|
@mrunalp Tests pass. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will release the MCS Label to be used again. Only do this if we
don't have another sandbox using the same label.
Also vendor in the latest selinux go bindings, which fixes a leak and
properly reserves the SELinux label we are going to use.
Signed-off-by: Daniel J Walsh [email protected]
Signed-off-by: Daniel J Walsh [email protected]