Skip to content

Fix fish shell export format - missing space after -g flag #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crhuber merged 2 commits into from
Nov 10, 2025
Merged

Fix fish shell export format - missing space after -g flag #32

crhuber merged 2 commits into from
Nov 10, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025 •
edited
Loading

The crumb get --export --shell=fish command was generating invalid fish syntax by concatenating the -g flag with the variable name.

Changes

  • pkg/commands/commands.go:291: Added missing space in format string

    // Before: set -x -gAPI_KEY secret123
fmt.Printf("set -x -g%s %s\n", varName, quotedValue)

// After: set -x -g API_KEY secret123  
fmt.Printf("set -x -g %s %s\n", varName, quotedValue)

  • integration_test.go: Added TestGetCommandExportFishFormat covering bash and fish export formats with quoted values

Note on show_values setting

The reported issue also mentioned show_values=true not working. Testing confirms this TOML setting works correctly - when enabled, crumb get displays the actual secret value instead of ****.

Original prompt

This section details on the original issue you should resolve

<issue_title>Toml file settings not working</issue_title>
<issue_description>setting show_values=true in toml file has no effect where the value is not shown
cat ~/.config/crumb/crumb.toml
shell=fish
show_values=true

crumb get /test/API_KEY

also the export command is not outputting in fish format

crumb get /test/API_KEY --export
export API_KEY=secret123</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix Toml file settings not working in crumb Fix fish shell export format - missing space after -g flag Nov 10, 2025
Copilot AI requested a review from crhuber November 10, 2025 18:43
@crhuber crhuber marked this pull request as ready for review November 10, 2025 20:22
@crhuber crhuber merged commit 03399d1 into main Nov 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crhuber crhuber crhuber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crhuber crhuber

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toml file settings not working

2 participants

@crhuber