Fix get command --export to use only last path segment as variable name #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getcommand with--exportflag was incorrectly using the full path to generate environment variable names instead of just the final segment. This caused confusing export statements where the variable name included the entire path hierarchy.Problem
When running:
The output was:
But users expect:
Root Cause
The
ExtractVarNamefunction in/pkg/storage/storage.gowas converting the entire path to an environment variable name by replacing all slashes with underscores, rather than extracting only the final path segment like the existingConvertPathToEnvVarfunction used by theexportcommand.Solution
Modified
ExtractVarNameto:/separatorsThis makes the behavior consistent between
get --exportand the standaloneexportcommand.Testing
ExtractVarNamewith various path formatsFixes #6.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.