[Domains] Improve representation of public suffix match results by class EffectiveTLD #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class EffectiveTldFinder.EffectiveTLD is used for two purposes:
Due to this dual use, there's some confusion what EffectiveTLD shall contain as a match result.
Let's look at two problematic matches:
*.bdin the public suffix list:domainit shows the literally matched suffix, but it does not provide the original line from the public suffix list:This PR addresses these two points – the results are now:
In detail:
wildcard(and all other flags) are transferred from the ETLD representing the public suffix line to that holding the match resultEffectiveTLD.getSuffix()which returns the suffix as specified in the public suffix list, e.g.*.bdgetDomain()still returns the literally matched suffix (ETLD), also for Unicode suffixes (IDNs)wildtowildcardandisWild()toisWildcard()