some messages polished #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@volodya-lombrozo please, check |
volodya-lombrozo
requested changes
Sep 17, 2025
Collaborator
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@yegor256 It looks fine to me when we use capital letters in logs, but it's a common practice to use lower-case in error messages. It's an idiomatic way, let's say.
internal/brain/deepseek.go
Outdated
| data, err := json.Marshal(body) | ||
| if err != nil { | ||
| return "", fmt.Errorf("error marshaling request body: %w", err) | ||
| return "", fmt.Errorf("Error marshaling request body: %w", err) |
Collaborator
There was a problem hiding this comment.
Error strings should not be capitalized
| @@ -1,3 +1,4 @@ | |||
| // Package facilitator is for the facilitator. | |||
Collaborator
There was a problem hiding this comment.
@yegor256 Do we need these meaningless comments?
Member
Author
There was a problem hiding this comment.
@volodya-lombrozo golangci-lint demands us to have them. I don't know how did it work without them.
Collaborator
There was a problem hiding this comment.
@yegor256 .golangci.yml
staticcheck:
checks: ["all", "-ST1005", "-ST1000"]
Member
Author
|
@volodya-lombrozo I reverted the changes, please look again |
volodya-lombrozo
approved these changes
Sep 17, 2025
Collaborator
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@yegor256 Looks good to me. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #113