Skip to content

Conversation

@pmor
Copy link
Member

@pmor pmor commented Jun 4, 2025

No description provided.

@sabify
Copy link
Contributor

sabify commented Jun 4, 2025

@pmor I believe all countries should have the iso_short_name and iso_short_name_lower_case fields, and both fields should be copy-pasted of their ISO representation.

Please consider the UPPERCASE form of a country ISO short name may be different from the lowercase form of it. For example, Turkey ISO short names are different in both forms. (It's different in the i character in both forms that it's unicode is not convertible in many PLs).

I want you to please use iso_short_name and iso_short_name_lower_case exactly the same as it is indicated in the ISO website; these are identifiers. iso_short_name should be the UPPERCASE form, and the iso_short_name_lower_case should be the lowercase form.

Some may experience regression in their data, but we shall have the correct data.

@sabify
Copy link
Contributor

sabify commented Jun 9, 2025

Please consider that based on the ISO data reference (sample), we need to keep the iso_short_name field and data as it is and just add another field for iso_short_name_uppercase for all countries.

@pmor pmor force-pushed the fix_iso_short_name_change branch from 9f54b42 to 8693433 Compare August 30, 2025 14:30
@pmor pmor force-pushed the fix_iso_short_name_change branch from 8693433 to 0df0e00 Compare September 29, 2025 15:42
@pmor pmor force-pushed the fix_iso_short_name_change branch from 0df0e00 to 68175b1 Compare September 29, 2025 15:48
@pmor
Copy link
Member Author

pmor commented Sep 29, 2025

At this time, I'm adding iso_short_name_lower_case to contain the changes from #907 and reverting iso_short_name to its previous values.

I will look into the uppercase field at a later date, and then make plans for a deprecation of iso_short_name with ample time given before the actual switch to uppercased data

@pmor pmor merged commit 2db6ebe into master Sep 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants