fix(956110): move rule to pl-2 #4344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
956110 is intended to match Ruby ERB templates within response bodies to detect data leakage, however this syntax also overlaps with some common JavaScript templating engines (Zabbix, WordPress, and Horde IMP). I don't see an way to modify this rule to prevent these false positives since the syntax is virtually identical so I'm moving this to level 2.
Closes #4343
PR Checklist
commentfield to write the expected behaviorFurther comments
N/A
For the reviewer
ctl:requestBodyAccess=Offwere used in the rule