Skip to content

fix(934140): update perl interpolation regex #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(934140): update perl interpolation regex #4250

wants to merge 2 commits into from

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Aug 31, 2025 •
edited
Loading

what

  • update perl interpolation regex
  • add extensive examples

why

  • fix potential ReDOS

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 31, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi force-pushed the fix/3QA-240315-2 branch from 13d8634 to eba91e9 Compare August 31, 2025 13:35
@fzipi fzipi requested a review from theseion August 31, 2025 13:37
@fzipi
fix(934140): update regex
2abebc6 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the fix/3QA-240315-2 branch from eba91e9 to 2abebc6 Compare August 31, 2025 14:03
@fzipi fzipi changed the title fix(934140): update regex fix(934140): update perl interpolation regex Aug 31, 2025
@fzipi fzipi requested a review from a team August 31, 2025 17:53
theseion
theseion requested changes Sep 1, 2025
View reviewed changes
@fzipi fzipi mentioned this pull request Sep 1, 2025
Open
theseion
theseion requested changes Sep 9, 2025
View reviewed changes
tests/regression/tests/REQUEST-934-APPLICATION-ATTACK-GENERIC/934140.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for @@{...

@fzipi
fix: update regex
5a6efa2 
Signed-off-by: Felipe Zipitria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xhoenix Xhoenix Xhoenix left review comments

@theseion theseion theseion requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzipi @theseion @Xhoenix