Thanks for the patch. Is there any other operator we are missing?

Does this even make sense then?

I looked at the operators from here.

Does this even make sense then?

coreruleset/regex-assembly/942120.ra

Line 35 in 738694e

[<>=!]{1,2}\s*all\b

No, that's unnecessary, going to remove it.

On a second thought, there are no tests for it, so can't say for sure exactly what they were targeting.

=all
!all
<all

Test ID 26 exists. But then the expansion part {1,2} is unnecessary.

I think it will never match the ,2} part, right? Will previously match the other operators.

From that list we are missing:

• -> (->> will already match)
• probably

  coreruleset/regex-assembly/942120.ra

  Line 15 in 738694e

  <=>

  will never match because of

  coreruleset/regex-assembly/942120.ra

  Line 13 in 738694e

  <=

I'm going to remove <=>, add -> and remove {1,2}. Are you okay with this @fzipi ?

Sounds good to me!

LGTM!

Yeah, moving into an include file would make sense, but I've only referred into the operators for SQLite, and we may need to look into other database engines, for e.g mysql.

This is now ready. LGTM!

We're getting there.