fix(932130): use lazy regex #3730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
reviewed
Jun 3, 2024
f65f101 to
4b8806d
Compare
theseion
reviewed
Jun 4, 2024
4b8806d to
16b9ad7
Compare
Member
Author
|
Ugh, looks like |
Xhoenix
requested changes
Sep 19, 2024
theseion
requested changes
Sep 19, 2024
Member
|
I tried |
Member
Author
mkdir abc
touch abc/myfile.txt
ls a[b///]c
myfile.txt |
Member
|
Didn't knew you meant it in shell context. I thought in regex terms. 🙂 |
Contributor
|
📊 Quantitative test results for language: |
9c570f7 to
b51d25d
Compare
theseion
requested changes
Jun 26, 2025
EsadCetiner
requested changes
Jul 8, 2025
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Esad Cetiner <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
29fa791 to
991579d
Compare
Xhoenix
reviewed
Sep 18, 2025
Comment on lines
+14
to
+17
| \$\([^()]*\) | ||
| \$\{[^{}]*\} | ||
| <\([^()]*\) | ||
| >\([^()]*\) |
Member
There was a problem hiding this comment.
Suggested change
| \$\([^()]*\) | |
| \$\{[^{}]*\} | |
| <\([^()]*\) | |
| >\([^()]*\) | |
| \$\([^()]+\) | |
| \$\{[^{}]+\} | |
| <\([^()]+\) | |
| >\([^()]+\) |
We should expect atleast one character for command execution, $() or ${} will result in nothing for the attacker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
.(anything) to[^\(\)], which performs better while keeping the meaningwhy