Avoid leaks at shutdown time #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with ASAN, StringVals continued to be referenced at shutdown because V8 wouldn't run GC and some string resources would continue to exists holding references. This is unfortunate for testing. Rework Done() to force garbage collection using --expose-gc. Also call some global shutdown functions for V8 Node.js and libuv. Modify some of the tests to disable leak checking, or call terminate() instead of exit. The issue here is that calling process.exit() doesn't go through Plugin::Done() and so the cleanup does not run. This could probably be improved with a custom exit handler and splitting Done() into a helper for cleaning up, but that's for another time. With these changes, it's now possible to remove the suppression configuration altogether, so I think that was worth it.
That one used the old analyzer_confirmation() event. Switch to analyzer_confirmation_info().
Collaborator
Author
|
Grumble, Ubuntu 24.04 with the distro provided libnode-dev package hangs on the |
This seems to fix the FinalizationRegistry test (and make it work).
6b496bf to
7a1a97f
Compare
timwoj
approved these changes
Nov 19, 2025
Collaborator
timwoj
left a comment
There was a problem hiding this comment.
Looks good to me. I'm kind of surprised that we weren't already calling the garbage collector at shutdown.
Collaborator
|
I can also confirm that this fixes the Zeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.