filter bidi isolates in notifications, fixes #60 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sjp4
approved these changes
Dec 17, 2025
Contributor
Author
|
I believe the build failure has nothing to do with the introduced changes. But please let me know if I should change something. |
Member
We recently fixed CI - you need to rebase on main for your branch to pass |
5bfb205 to
0bd9ed5
Compare
Contributor
Author
|
Thanks, @sjp4; I rebased on |
sjp4
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I performed a minimal test; this seem to indeed remove the squares around the sender's name.