Skip to content

Enable sort notification list for iOS #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjp4 merged 3 commits into from
Dec 17, 2025
Merged

Enable sort notification list for iOS #65

sjp4 merged 3 commits into from
Dec 17, 2025

Conversation

@asyba
Copy link
Contributor

@asyba asyba commented Dec 15, 2025

Added sorting dropdown for the Notification list section for iOS:

Android: Uses pebbleFeatures.supportsNotificationAppSorting() which returns true only for Android
This displays a filter chip row below the search bar with two chips: "Notified only" and a sort dropdown.
This adds an entire extra row to the UI.

iOS: I added a sort icon button directly in the toolbar actions, next to the search bar.
This approach doesn't add an extra row/bar to the UI.
I couldn't reuse supportsNotificationAppSorting() because it would show the "Notified only" that is specific for Android.

The "Count" sorting option is now hidden on iOS since doesn't provide access to notification history like Android does.

@sjp4
Copy link
Member

sjp4 commented Dec 15, 2025

The goal with PebbleFeatures is to remove and isIos()/isAndroid() checks from the UI code, so ideally we should just add more functions to PebbleFeatures to support making this change. I think ideally we'd keep the UI consistent between the platforms, too (i.e. using filter chips, rather than a dropdown in the topBar. We could probably do this without much code change by adding another PebbleFeatures entry or two, and a couple more conditionals in the existing filter row code.

@asyba
Copy link
Contributor Author

asyba commented Dec 15, 2025 •
edited
Loading

The goal with PebbleFeatures is to remove and isIos()/isAndroid() checks from the UI code, so ideally we should just add more functions to PebbleFeatures to support making this change. I think ideally we'd keep the UI consistent between the platforms, too (i.e. using filter chips, rather than a dropdown in the topBar. We could probably do this without much code change by adding another PebbleFeatures entry or two, and a couple more conditionals in the existing filter row code.

got it.
what should be done for the "Notified Only" since for iOS is not supported.
I try removing but the UI shows in the middle and bad.
maybe show the "Notified Only" but as disabled? or I have to move the "Recent" to the right size?
image

image

@sjp4
Copy link
Member

sjp4 commented Dec 16, 2025

maybe show the "Notified Only" but as disabled?

That sounds OK!

@asyba
Copy link
Contributor Author

asyba commented Dec 16, 2025

image

@asyba
Copy link
Contributor Author

asyba commented Dec 16, 2025

maybe show the "Notified Only" but as disabled?

That sounds OK!

done

@sjp4 sjp4 merged commit 09f300c into coredevices:master Dec 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjp4 sjp4 sjp4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asyba @sjp4