settings: more permissive close url interceptor for non-compliant URLs #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
These two apps:
Do not use
pebblejs://close#URL scheme when passing data back to the mobile app.The pebble documentation specifically states this must be the case: https://pebble.github.io/pebblejs/#settings
The original pebble app worked with these apps, so pebble technology corp was aware that not all developers would follow the documentation by the book and added some wiggle room in how to intercept the close URLs.
I used this snippet to develop the fix: