Laravel 8 support #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumped PHPUnit from `^8.0` to `^8.4` to match Laravel 8
|
This build fails because it's using PHP 7.2, and Laravel 8 requires https://github.com/squatto/acf/blob/c01a5d4e5331a329df16e21d090886f7b3327667/readme.md#L22-L27
EDIT: I adjusted the travis builds to test v4 against 7.2, 7.3, and 7.4 and v5 against 7.3 and 7.4. All builds are passing now 👍🏻 |
* Corcel v4 tested with PHP 7.2, 7.3, and 7.4 * Corcel v5 tested with PHP 7.3 and 7.4 * Removed deprecated/ignored `sudo` setting * Moved database import process into `before_script` * Moved `composer self-update` into `before_install` * Moved `composer install` into `install`
|
If you can't tell, this is my first foray into Travis builds. Sorry for the barrage of commits and builds!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Laravel 8.x by way of adding support for Corcel 5.x (added by Corcel PR #531). The PHPUnit version constraints were changed to line up with Laravel 8's PHPUnit version constraints.
I based this branch on
masterbecausedevelopisn't in sync withmasteryet (#93 brings them in sync but it isn't merged yet)