Skip to content

add missing monitoring category #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2025
Merged

add missing monitoring category #671

merged 3 commits into from
Oct 3, 2025

Conversation

@Gakhramanzode
Copy link
Contributor

add the project https://github.com/prymitive/karma for monitoring category

@Gakhramanzode
Copy link
Contributor Author

@apetruhin what do you think about this PR?

@def
Copy link
Member

def commented Oct 3, 2025

The problem with this PR is that both the title and commit message are not meaningful.

@Gakhramanzode Gakhramanzode changed the title Update application_category.go add missing monitoring category Oct 3, 2025
@Gakhramanzode
Copy link
Contributor Author

The problem with this PR is that both the title and commit message are not meaningful.

fix it

def
def reviewed Oct 3, 2025
View reviewed changes
@def
Copy link
Member

def commented Oct 3, 2025

I don’t think it’s a good idea to match karma this way. Someone might install it with a different Helm release name, for example. I’d suggest adjusting your instance config with this pattern, since we can’t be sure it’ll work for everyone

@Gakhramanzode
Copy link
Contributor Author

I understand your vision and what you mean. I removed this app

@def def merged commit 4f8baf1 into coroot:main Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@def def def approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gakhramanzode @def