Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Bring TracingExplanationDialog back (EXPOSUREAPP-5813) #2628

Merged
merged 6 commits into from
Mar 16, 2021
Merged

Bring TracingExplanationDialog back (EXPOSUREAPP-5813) #2628

merged 6 commits into from
Mar 16, 2021

Conversation

@jurajkusnier
Copy link
Contributor

@jurajkusnier jurajkusnier commented Mar 16, 2021

Fixing
Tracing explanation dialog got removed from the onboarding process
Testing
Reset app & go through onboarding. You should see the Tracing explanation dialog with new strings.

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Mar 16, 2021
@jurajkusnier jurajkusnier added this to the 1.15.0 milestone Mar 16, 2021
@jurajkusnier jurajkusnier requested review from a team March 16, 2021 12:55
@harambasicluka harambasicluka self-assigned this Mar 16, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.1% 8.1% Coverage
0.0% 0.0% Duplication

harambasicluka
harambasicluka reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
looks good :)

@ralfgehrer should we keep the string changes in to not trigger a new translation? But this will cause merge problems with the translation delivery tomorrow...

@ralfgehrer ralfgehrer self-assigned this Mar 16, 2021
@harambasicluka
Copy link
Contributor

harambasicluka commented Mar 16, 2021

I also tested an update to a newer version (VERSION_MAJOR=2) and it isn't shown again 👍

@jurajkusnier
Copy link
Contributor Author

jurajkusnier commented Mar 16, 2021

@ralfgehrer should we keep the string changes in to not trigger a new translation? But this will cause merge problems with the translation delivery tomorrow...

Everything in the PR is already translated and some texts were removed in the previous commits so we need to update string files anyway to display something in the popup.

@ralfgehrer
Copy link
Contributor

ralfgehrer commented Mar 16, 2021

@ralfgehrer should we keep the string changes in to not trigger a new translation? But this will cause merge problems with the translation delivery tomorrow...

Let's keep the changes here and request another translation upload once merged.

ralfgehrer
ralfgehrer approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Pixel (Andoid 10)

@ralfgehrer ralfgehrer added the text change PRs with text changes. label Mar 16, 2021
@ralfgehrer ralfgehrer merged commit 5239015 into release/1.15.x Mar 16, 2021
@ralfgehrer ralfgehrer deleted the fix/5813-add_onboarding_risiko_ermittlung_dialog branch March 16, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@harambasicluka harambasicluka harambasicluka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ralfgehrer ralfgehrer

@harambasicluka harambasicluka

Labels

bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes.

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jurajkusnier @harambasicluka @ralfgehrer