Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Dec 11, 2020

Because we stored the information "we have so far" on each symptom step, aborting early could lead to the constellation of Symptoms(startOf=null,indication=POSITIVE). The new submission flow behavior was missunderstood.

This PR fixes the behavior by switching to the 1.8.x style of symptom indication:

  • Pass the indication from the indication fragment to the calendar fragment using navigation arguments
  • Only when the symptom data is completed on the calendar fragment, is the internal SubmissionSettings.currentSymptoms value updated.

Test

  • The original issue can be reproduced by performing a positive submission, and on the symptom indication screen, select "yes", but then abort symptom indication via the X in the toolbar.

….NO_INFORMATION.

The information is based from one fragment to the next.
The stored symptom data is only updated if the last fragment successfully completes.
@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers labels Dec 11, 2020
@d4rken d4rken added this to the 1.9.0 milestone Dec 11, 2020
@d4rken d4rken marked this pull request as ready for review December 11, 2020 13:56
@d4rken d4rken requested a review from a team December 11, 2020 13:56
…on/symptoms/calendar/SubmissionSymptomCalendarViewModel.kt

Co-authored-by: chris-cwa <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

65.3% 65.3% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 3e51ced into release/1.9.x Dec 11, 2020
@ralfgehrer ralfgehrer deleted the fix/4260-symptom-TRLs branch December 11, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants