Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@chiljamgossow
Copy link
Contributor

@chiljamgossow chiljamgossow commented Dec 10, 2020

Removes abort dialog on back press to allow back navigation
Replaces app bar icon with X to indicate abort, while keeping the dialog here

replace app bar icon with X to indicate abort
@chiljamgossow chiljamgossow added the maintainers Tag pull requests created by maintainers label Dec 10, 2020
@chiljamgossow chiljamgossow added this to the 1.9.0 milestone Dec 10, 2020
@chiljamgossow chiljamgossow requested a review from a team December 10, 2020 07:27
@ralfgehrer ralfgehrer self-assigned this Dec 10, 2020
@ralfgehrer
Copy link
Contributor

Screenshot_20201210-112921
All works except that I would have expected that pop-up - when going back by android's back button - on the first screen of the symptom flow instead of on top of the test result. Is this intended?

@chiljamgossow
Copy link
Contributor Author

The idea is to allow the user to go back as long as the flow allows and it does not cause an issue. So going back from the intro is fine, while going back from test result is not.

@d4rken d4rken self-assigned this Dec 10, 2020
@d4rken d4rken self-requested a review December 10, 2020 14:46
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@d4rken d4rken merged commit fd953e4 into release/1.9.x Dec 10, 2020
@d4rken d4rken deleted the feature/4201-symptom-navigation branch December 10, 2020 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants