This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Deduplicate and format technical HTML file (closes #1757) #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@fynngodau Please target branch |
ralfgehrer
previously approved these changes
Dec 9, 2020
Contributor
ralfgehrer
left a comment
There was a problem hiding this comment.
Many thanks for the effort. Looks good from my POV. Double-checking with the architects and UA. Meanwhile, you might want to change the base branch to release/1.9.x
Add br tags where necessary and reduce confusion by adding a horizontal ruler in front of where the license texts start.
Contributor
Author
|
@d4rken @ralfgehrer Okay, I changed the base branch |
thomasaugsten
approved these changes
Dec 9, 2020
ralfgehrer
approved these changes
Dec 10, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1757, the technical HTML file is currently duplicate and should be deduplicated to reduce confusion. It is also not formatted well.
This PR addresses these issues by removing the duplicate files, renaming the remaining one, changing strings to point to the new file and by adding
<br/>tags where necessary as well as one horizontal ruler (<hr/>). I think the file could be formatted even better (with meaningful headlines over each license), but I didn't do that to avoid changing the actual text.