New Submission Flow: new test result notification (EXPOSUREAPP-4134) #1825
Conversation
…-new-notification
Adjusted tests and classes
…-new-notification
|
How can we test this? |
AndroidMedaGalaxy
left a comment
There was a problem hiding this comment.
Note: Checked with the Test Menu.
- Tested with positive Result : Deep linking works and the Submission Flow starts when clicked on the notification
- Tested with Negative REsult : Deep linking works here again and Result Page is shown after clicking on the notification. of course, the result visible in the screen is negative as it should.
Long story short, All looks good to me. (. _ .)/ \(.__.)
Thanks
|
When I tested with the test menu, screens were incomplete. I do not know whether it works fine in a more realistic scenario. |
# Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/api/ui/TestForAPIFragment.kt # Corona-Warn-App/src/deviceForTesters/res/layout/fragment_test_for_a_p_i.xml
AndroidMedaGalaxy
left a comment
There was a problem hiding this comment.
Tested
Scenario 1: Positive test with cancelled submission flow after QR scan
- > Positive notification fired from Test API - > Clicked on notification - > Submission flow start screen "Your test is available" was opened
Scenario2 : Negative test
- > Negative notification fired from Test API - > Clicked on notification - > Test Result screen was opened
Tried interchanging the Positive and Negative notifications buttons in Test API regardless of the test result
All works good. ヽ(ヅ)ノ
|
Kudos, SonarCloud Quality Gate passed! |
New notification for submission flow.
Notification creation kept the same. Main difference is in intent that leads to different screens depending on test result.
For quick intent test new button was introduced in test menu (Test for API).
For better testability NotificationHelper was refactored from object to injectable class with further refactoring of some classes and tests 🤖