Fix PopupTo Backstack issue (EXPOSUREAPP-4123) #1813
Conversation
d4rken
left a comment
There was a problem hiding this comment.
Did not work for all screens.
- Scan positive QR code
- Give consent
- Click "Finish" without symptom input
- We end up on the home screen but on "back button" we still end up on the test result.
Same when ending the submission from SubmissionSymptomIntroductionFragment.
I've added the proposed solution with app:popUpTo="@id/nav_graph" to all navgraph actions leading from submission to the home fragment and it works for me now.
Please retest/review this @ritsam @chiljamgossow
|
I cleaned up the graph. The app should only close after the mainFragment is shown. Many actions popUpTo mainFragment with popUpInclusive = true, so the mainFragment gets removed from the stack and any following popUpTo mainFragment has no effect. |
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Back navigation popupstack fixed
Steps to reproduce
Testing with release 1.9.x
Positive QR Code scanned > consent aborted by refusing to submit keys > ending up on the home screen. >
Click "Andere Warnen" on the home screen > consented > shared keys > Submit keys without symptoms > come back on the screen by selecting yes in the popup > The app should close on Android's back key press. but it comes back to the thank you screen again.
This behaviour is the same for all the screens in Submission No consent Keys flow ( only till thank you screen)
Testing with this PR
Perform all the actions as above but when clicked back button on home screen, the App should close now instead of going back to the previous fragment.
Changes
nav_graph has been updated where app:popUpTo="@id/mainFragment" is replaced with app:popUpTo="@id/nav_graph"
Reason for this change
Somehow there could be multiple instances of mainfragment in the backstack. we're clearing the backstack completely to make a fresh start each time we navigate to mainfragment