Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Dec 2, 2020

No description provided.

Storing Symptoms and TEKs.

TODO:
* Change upload task to use stored data.
* Blocking upload task
* Tests
Integrate permission request and automatic TEK history update.

TODO:
* Cancel dialog
* Blocking upload task
* Tests
@d4rken d4rken added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels Dec 2, 2020
@d4rken d4rken added this to the 1.9.0 milestone Dec 2, 2020
# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/api/ui/TestForAPIFragment.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/nearby/modules/tracing/DefaultTracingStatus.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/symptoms/calendar/SubmissionSymptomCalendarViewModel.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/symptoms/introduction/SubmissionSymptomIntroductionViewModel.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/warnothers/SubmissionResultPositiveOtherWarningViewModel.kt
@d4rken d4rken marked this pull request as ready for review December 3, 2020 17:00
@d4rken d4rken requested a review from a team December 3, 2020 17:00
@ralfgehrer
Copy link
Contributor

ralfgehrer commented Dec 3, 2020

iOS vs Andorid difference
Screenshot 2020-12-03 at 18 33 37

@harambasicluka
Copy link
Contributor

image
start submission flow -> enter valid positive tan -> click on x -> see popup -> click on warn

get redirected to this screen:
image

I would expect that the popup is closed and stays on the same screen, that's at least the behaviour in other parts.

@ralfgehrer
Copy link
Contributor

Flags are off - should be within the border

Screenshot 2020-12-03 at 18 35 23

@AndroidMedaGalaxy
Copy link
Member

Flags are off - should be within the border

Screenshot 2020-12-03 at 18 35 23

Hi Ralf,

What I understood by borders you mean within those two lines right? IF that's the case, the designs had a mixed UI representation, perhaps more clarification from the design side is needed.

@harambasicluka
Copy link
Contributor

The flow isn't correct.

image

Positive test result on home > warn others > give ENF consent > go ahead with symptoms

Expected: go directly to the calendar view symptom screen

image

Actual:

image

@ralfgehrer
Copy link
Contributor

I have scanned a positive QR Code with given consent, went into the symptoms screen aborted, the keys were submitted and the thank you screen was shown. So far so good.
BUT, now I can navigate back (via androids back button/gesture) and end up on the symptom screen again.
Furthermore, aborting the symptoms flow results in a 400 error as we try to upload the keys again.

@harambasicluka
Copy link
Contributor

The flow isn't correct.

image

Positive test result on home > warn others > give ENF consent > go ahead with symptoms

Expected: go directly to the calendar view symptom screen

image

Actual:

image

isn't bug, the implementation is correct

@ralfgehrer
Copy link
Contributor

"Andere Warnen" screen: flags are missing entirely while the flags are present on the "Ihr Einverständnis" screen (hence, not a config issue)

Screenshot 2020-12-03 at 19 10 27

@ralfgehrer
Copy link
Contributor

I have scanned a positive QR Code with consent aborted, refused to submit keys, ended up on the home screen.
Clicked "Andere Warnen" on the home screen, consented, shared, ended on the thank you screen (fragment), submitted keys without symptoms.

BUT, now I can navigate back (via androids back button/gesture) and end up on the thank you screen again.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

19.7% 19.7% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit 950653c into release/1.9.x Dec 3, 2020
@d4rken d4rken deleted the feature/3748-submission-upload branch December 3, 2020 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants