This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Fix possible notification loop (EXPOSUREAPP-4036) #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed the issue that if no new risk level calculation happened, and the last one triggered a notification, killing and restarting the app would also trigger a notification.
chris-cwa
approved these changes
Nov 27, 2020
Comment on lines
+51
to
+57
| val lastCheckedResult = riskLevelSettings.lastChangeCheckedRiskLevelTimestamp | ||
| if (lastCheckedResult == newResult.calculatedAt) { | ||
| Timber.d("We already checked this risk level change, skipping further checks.") | ||
| return | ||
| } | ||
| riskLevelSettings.lastChangeCheckedRiskLevelTimestamp = newResult.calculatedAt | ||
|
|
Member
There was a problem hiding this comment.
is there any advantage to create the variable lastCheckedResult ? can we not directly compare riskLevelSettings.lastChangeCheckedRiskLevelTimestamp in the condition?
The comment is more for an information seeking purpose rather that a suggestion.
Suggested change
| val lastCheckedResult = riskLevelSettings.lastChangeCheckedRiskLevelTimestamp | |
| if (lastCheckedResult == newResult.calculatedAt) { | |
| Timber.d("We already checked this risk level change, skipping further checks.") | |
| return | |
| } | |
| riskLevelSettings.lastChangeCheckedRiskLevelTimestamp = newResult.calculatedAt | |
| if (iskLevelSettings.lastChangeCheckedRiskLevelTimestamp == newResult.calculatedAt) { | |
| Timber.d("We already checked this risk level change, skipping further checks.") | |
| return | |
| } | |
| riskLevelSettings.lastChangeCheckedRiskLevelTimestamp = newResult.calculatedAt | |
Member
Author
There was a problem hiding this comment.
Readability, inlining the variable exceeds our maximum line length.
BMItr
approved these changes
Nov 30, 2020
ralfgehrer
reviewed
Nov 30, 2020
Contributor
ralfgehrer
left a comment
There was a problem hiding this comment.
Code looks fine. Testing now. Should also fix another issue (EXPOSUREAPP-4050)
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that if no new risk level calculation happened, and the last one triggered a notification, killing and restarting the app would also trigger a notification.
To test this you'd have to get to a state where the last risk level calculations were LOW_RISK -> HIGH_RISK, and then just kill the app process and open the app again.
Also: While debugging this I noticed a few cryptic log messages which needed explicit tags.