This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Test feature to fake high/low risk encounters via exposure windows (DEV) #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfgehrer
reviewed
Nov 24, 2020
...esters/java/de/rki/coronawarnapp/nearby/modules/exposurewindow/FakeExposureWindowProvider.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Nov 24, 2020
...esters/java/de/rki/coronawarnapp/nearby/modules/exposurewindow/FakeExposureWindowProvider.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
approved these changes
Nov 24, 2020
Contributor
|
tested on Pixel 2 Device. Code is excluded to deviceForTesters correctly but TestSettings.kt (necessarily). One optional suggestion: |
Member
Author
Sure maybe not now? Don't want to delay the PR. The next person that adds a new fake data, can change the orders I just added some defaults, might not cover all UI states we need. |
|
Kudos, SonarCloud Quality Gate passed!
|
BMItr
approved these changes
Nov 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's currently way too complicated to get the app into risk states with encounters to test various app behaviors, I wrote this test feature which I think would be useful for everyone else too.
The
deviceForTestersflavor has a differentExposureWindowsProvider.Depending on which debug option was chosen exposure windows window data will be loaded from json files and then returned via the
ENFClient.From the apps perspective it will look like Googles exposure detection calculated windows with low/high risk encounters after the last submission.
Based on @bmitter
ExposureWindowProviderand @mlenkeit ExposureWindow test data concepts.Testing
deviceForTestersthe option is there, and that indevicethe whole code is not included.