Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Exposure windows ui changes strings (EXPOSUREAPP-3855) #1697

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Exposure windows ui changes strings (EXPOSUREAPP-3855) #1697

merged 2 commits into from
Nov 23, 2020

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Nov 23, 2020

New UI strings to translate.

@janetback @SabineLoss

Do we actually need to have all plural variants in all locales for the translation tool?

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Nov 23, 2020
@d4rken d4rken added this to the 1.8.0 milestone Nov 23, 2020
@d4rken d4rken requested a review from a team November 23, 2020 13:39
@harambasicluka harambasicluka added the text change PRs with text changes. label Nov 23, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harambasicluka harambasicluka merged commit 0fb49fd into release/1.8.x Nov 23, 2020
@harambasicluka harambasicluka deleted the feature/3855-exposure-windows-UI-changes-strings branch November 23, 2020 15:38
janetback
janetback reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@janetback
Copy link
Contributor

janetback commented Nov 24, 2020

New UI strings to translate.

@janetback @SabineLoss

Do we actually need to have all plural variants in all locales for the translation tool?

Hi @d4rken
I checked with Albert Kwiatkowski - here is his reply:
"Ja, aber wir haben bereits Plurals in iOS in einer separaten Datei stringdict https://github.com/corona-warn-app/cwa-app-ios/blob/release%2F1.8.x/%2Fsrc%2Fxcode%2FENA%2FENA%2FResources%2FLocalization%2Fde.lproj%2FLocalizable.stringsdict und bei Android sind die in der Datei eingebettet.
Daran kann sich der Entwickler anlehnen (wenn es um neue Texte geht)
"

@d4rken d4rken mentioned this pull request Nov 24, 2020
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SabineLoss SabineLoss Awaiting requested review from SabineLoss

2 more reviewers

@janetback janetback janetback left review comments

@harambasicluka harambasicluka harambasicluka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintainers Tag pull requests created by maintainers text change PRs with text changes.

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@d4rken @janetback @harambasicluka