This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Ignore negative secondsSinceLastScan (EXPOSUREAPP-3897) #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
BMItr
approved these changes
Nov 23, 2020
Contributor
BMItr
left a comment
There was a problem hiding this comment.
looks good to me. thx for adding adjusten test.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API can return a negative value for secondsSinceLastScan (seen on my device). Most likely, this is related to time travel and should not happen in production. Anyway, to avoid potential issues from this in the first place - regardless of whether it's PROD or testing - the client should handle this properly.