This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Fix config default values not being used if protobuf is missing the data structures (EXPOSUREAPP-3856) #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-cwa
reviewed
Nov 18, 2020
| Timber.tag(TAG).d("Returning local config, still valid.") | ||
| return localConfig | ||
| } else { | ||
| Timber.tag(TAG).d("Local app config was unavailable(${localConfig == null} or invalid.") |
Contributor
There was a problem hiding this comment.
i would prefer severity 'warn' not 'debug'
Member
Author
There was a problem hiding this comment.
Maybe invalid is too strong of a word here, the local config is invalid if it older than the CDNs cache header specifies, which is currently just 5min, so we would get the warning a lot.
chris-cwa
approved these changes
Nov 18, 2020
harambasicluka
approved these changes
Nov 18, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.