Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Nov 17, 2020

They are not actively maintained, not really used and just creating techdebt.

Testing

  • Smoke test the app
  • Check that the debug menu still works okay

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Nov 17, 2020
@d4rken d4rken added this to the 1.8.0 milestone Nov 17, 2020
@d4rken d4rken requested a review from a team November 17, 2020 09:18
@SamuraiKek SamuraiKek self-assigned this Nov 17, 2020
SamuraiKek
SamuraiKek previously approved these changes Nov 17, 2020
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the debug menu and everything looks good. I was able to switch environments properly, the logs were working and, as expected, the background notifications were no longer there.

@harambasicluka
Copy link
Contributor

Testers are using this. Need to discuss how we go ahead.

@harambasicluka harambasicluka added could be moved to next release This PR isn't so urgent, so this could be moved to the next release. and removed could be moved to next release This PR isn't so urgent, so this could be moved to the next release. do not merge labels Nov 19, 2020
harambasicluka
harambasicluka previously approved these changes Nov 19, 2020
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified with testers, they are also only going into the logs. If a tester isn't sure how to work with logs we are happy to help!

# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/diagnosiskeys/download/DownloadDiagnosisKeysTask.kt
@d4rken d4rken dismissed stale reviews from harambasicluka and SamuraiKek via b1bb123 November 19, 2020 18:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit 298fb09 into release/1.8.x Nov 19, 2020
@d4rken d4rken deleted the fix/remove-debug-notifications branch November 19, 2020 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants