Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@chris-cwa
Copy link
Contributor

No description provided.

AlexanderAlferov and others added 25 commits October 16, 2020 18:26
* Don't rename the APK on `device` flavor builds.
It breaks internal pipelines.

* Better log output.
* + config changed detector

* tests

* ConfigChangeDetector.kt improvements.
* Fix config collecting scoping
* Move the identifier update into the RiskLevelTask
* Add test coverage

* Logs NO-OPs too.

* Filter emissions early if the value didn't change.

* extracted constant

Co-authored-by: Matthias Urhahn <[email protected]>
Change-Id: I64e8b3a17346d3e14e3c7306c89100633afc104e

Co-authored-by: Ralf Gehrer <[email protected]>
* Catch cancellation exceptions for coroutines launched on the viewModelScope.

* Use the viewmodel provided launch method to use common handling.

Co-authored-by: harambasicluka <[email protected]>
Co-authored-by: chris-cwa <[email protected]>
#1604)

* Flush the json data after writing it, otherwise if the app process dies, we end up with an empty file.
GSON deserializes this into a null object that looks like a non-null object until it is evaluated some time later.

Force an evaluation via `require(it.size >= 0)` and delete the corrupt data file when catching the exception.

* Show a visible error dialog if we fail to save data.

* Used buffered versions of readers and writer.
…23) (#1597)

* Update RiskLevelRepository.kt

* Removed comment

Co-authored-by: harambasicluka <[email protected]>
* Fix HotDataFlow behavior.
* Prevent re-execution of past submissions when the observable goes cold.
* Guard internal value updates with a mutex in case the value update is not as thread-safe as we think it is.

* Fix problematic testcases.
…1608)

* Make config sharing behavior `SharingStarted.Lazily`. (start once, never release)
Otherwise classes that are just interested in the current config, if there is no other subscriber active,
would launch the `startValueProvider` and pull a config each time.

The ExposureDetectionTracker is such a candidate that would like to use the latest config every ~3min.

While this already no longer happens since "Track config changes" (4d1ecb5),
because there is no a class that is permanently subscribed to `currentConfig`, we should not rely on side-effects,
so let's make the sharing behavior explicit.

* Fix test regression.

Co-authored-by: harambasicluka <[email protected]>
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/nearby/modules/detectiontracker/ExposureDetectionTrackerStorage.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/flow/HotDataFlow.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/flow/HotDataFlowTest.kt
#	gradle.properties
…age sind, können nicht gelöscht werden (EXPOSUREAPP-2398) (#1586)

* 1. Replaced redundant uiStateState during test result fetch with a NetworkRequestWrapper that is able to represent multiple states. This allows for better request state handling throughout the app
2. Completely removed the SubmissionViewModel
3. Failure to fetch the test should now always display the invalid test card on the home screen

Signed-off-by: Kolya Opahle <[email protected]>

* Keep displaying fetching card on server errors as this usually does not indicate any problems with the test itself

Signed-off-by: Kolya Opahle <[email protected]>

* Fixing unit tests (mostly just syntax, one test case changed due to new card)

Signed-off-by: Kolya Opahle <[email protected]>

* Promoted unknown host exception to server exception

Co-authored-by: chris-cwa <[email protected]>
Co-authored-by: harambasicluka <[email protected]>
@chris-cwa chris-cwa requested a review from a team November 17, 2020 09:04
@chris-cwa chris-cwa added the maintainers Tag pull requests created by maintainers label Nov 17, 2020
@chris-cwa chris-cwa added this to the 1.8.0 milestone Nov 17, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit c964aca into release/1.8.x Nov 17, 2020
@d4rken d4rken deleted the release1.7_to_1.8 branch November 17, 2020 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.