Fix missing error dialog (DEV) #1564
Conversation
| fun report(throwable: Throwable, tag: String? = null, info: String? = null) | ||
|
|
||
| companion object { | ||
| val isAUnitTest: Boolean by lazy { |
There was a problem hiding this comment.
The val could be moved outside the interface, so the companion object is not needed any more.
It seems that isAUnitTest is not a property of the BugReporter.
There was a problem hiding this comment.
Then it's resolved for any autocompletion call though, e.g. when typing "is...", we would get isAUnitTest as suggestion, whereas now its context relation is to the bug reporting code is clear. I'd prefer not to have such a niche/workaround piece of code be part of general suggestions. What do you think?
There was a problem hiding this comment.
I understand where you are coming from. It makes life easier when writing new code and one knows where to find that method. For me, when reading the source code, BugReporter.isAUnitTest would be confusing. However, it is not bug.
There was a problem hiding this comment.
Would you find it less confusing if we move it to CWADebug.isAUnitTest?
|
Kudos, SonarCloud Quality Gate passed!
|
Didn't we miss it? The error dialog? 🤗