Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Remove magicnumbers check (DEV) #1552

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Remove magicnumbers check (DEV) #1552

merged 1 commit into from
Nov 9, 2020

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Nov 6, 2020

Decided as a team that we'd rather remark magic-number issues in PRs instead of requiring suppressing annotation everywhere.

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Nov 6, 2020
@d4rken d4rken requested a review from a team November 6, 2020 19:39
@harambasicluka harambasicluka added this to the 1.7.0 milestone Nov 9, 2020
@ralfgehrer ralfgehrer merged commit 1011707 into release/1.7.x Nov 9, 2020
@ralfgehrer ralfgehrer deleted the fix/remove-magicnumbers-check branch November 9, 2020 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@harambasicluka harambasicluka harambasicluka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@d4rken @ralfgehrer @harambasicluka