This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Update Risk Score more than once a day (EXPOSUREAPP-3455) #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports new logic for more frequent downloads First draft.
Remove 24 hour mode options, no longer used.
…e-updates-download-and-submission-v2
…ads via app config.
…key download test fragment.
…e-updates-download-and-submission-v2
…`getting completed keys`
…duce server hits.
ralfgehrer
reviewed
Nov 9, 2020
...ForTesters/java/de/rki/coronawarnapp/test/keydownload/ui/KeyDownloadTestFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Nov 9, 2020
Corona-Warn-App/src/deviceForTesters/res/layout/fragment_test_keydownload.xml
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Nov 9, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/mapping/DownloadConfigMapper.kt
Outdated
Show resolved
Hide resolved
…xposureDetectionParameters.overallTimeoutInSeconds)
(Makes timetravel testing difficult, and a real abort reason would be a crash on the day index)
Member
Author
Contributor
chiljamgossow
left a comment
There was a problem hiding this comment.
It looks fine to me (with my limited knowledge of the project).
…e-updates-download-and-submission-v2
…n that "fakes" the connection status to metered. It's now also part of the `TestSettings` and the connection state is faked for the `NetworkStateProvider` class which may be reused.
…n that "fakes" the connection status to metered. It's now also part of the `TestSettings` and the connection state is faked for the `NetworkStateProvider` class which may be reused.
…ons. The app config alone determines which locations we try to sync.
…e-updates-download-and-submission-v2
…core-updates-download-and-submission-v2' into feature/3455-more-frequent-riskscore-updates-download-and-submission-v2
mlenkeit
approved these changes
Nov 11, 2020
Member
mlenkeit
left a comment
There was a problem hiding this comment.
I think we can leave it as-is for now to build the first RC and to the necessary minor changes in a follow-up PR for the next RC
1 task
harambasicluka
approved these changes
Nov 11, 2020
ralfgehrer
approved these changes
Nov 11, 2020
Contributor
|
Would appreciate more than 2 approvals on such a large PR. |
BMItr
approved these changes
Nov 11, 2020
…e-updates-download-and-submission-v2
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a hybrid approach of day and hour key packages to provide risk score updates as often as the quota allows.
TODO
Out of scope
Testing
de.rki.coronawarnapp.diagnosiskeys)