This repository was archived by the owner on Jun 20, 2023. It is now read-only.
1.7 to 1.8 #1557
Merged
1.7 to 1.8 #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Harmonization of the expired QR-Code * implmentation and refactoring of the asyncRegisterDevice method * fix detekt pipeline issue * test failing pipeline fix * QRCode Exceotion, observevent and timestamp improvements as per code reviews * removed deregistration logic from Fragment to viewModel UI Thread protection as this is important logic and should run on ViewModel * Code conflict resolution * ktlint fixes * changin the method deregisterTestFromDevice() to private * scanStatus SingleLIveEvent and relevant test cases added Co-authored-by: harambasicluka <[email protected]>
…#1545) * converted RetrieveDiagnosisKeysTransaction to Task * cherry picked and solved access to the new task * fixed background workers * fixed background workers * detekt ktlint unit test * ktlint * check cancel * fixed flow * fixed flow * fixed flow * fixed typo * Make klint happy. * Little refactoring to address PR comments (DI instead of static access). Co-authored-by: harambasicluka <[email protected]> Co-authored-by: Matthias Urhahn <[email protected]>
janetback
approved these changes
Nov 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
d4rken
approved these changes
Nov 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.