Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Reminder to share a positive test result (EXPOSUREAPP-3551) #1556

Merged
merged 16 commits into from
Nov 10, 2020
Merged

Reminder to share a positive test result (EXPOSUREAPP-3551) #1556

merged 16 commits into from
Nov 10, 2020

Conversation

@ralfgehrer
Copy link
Contributor

@ralfgehrer ralfgehrer commented Nov 9, 2020

  • Notification is shown 2 hours after the user has seen the positive test result (after he opened the screen with the positive test result) to remind the user in case the test result was not shared
  • After 4 hours an additional reminder is shown if the test result is still not shared-
  • No further reminder is shown
  • On Android, the scheduling might not be exactly 2h
  • A click on the notification directly leads to the test result screen from where others can be warned
  • After a reset of the App the notification shall be canceled

How to test:
To shorten the time span, developers can adopt the duration in the NotificationConstants class (see POSITIVE_RESULT_NOTIFICATION_INITIAL_OFFSET and POSITIVE_RESULT_NOTIFICATION_INTERVAL).

  1. Scan a positive QR Code or TeleTan.
  2. The notification will be triggered either in (a) the positive test result screen or (b) on the home screen that shows a positive test result for the first time.

positivetestresultnotification

@ralfgehrer ralfgehrer added maintainers Tag pull requests created by maintainers prio PRs to review first. labels Nov 9, 2020
@ralfgehrer ralfgehrer added this to the 1.7.0 milestone Nov 9, 2020
@ralfgehrer ralfgehrer requested a review from a team November 9, 2020 06:07
@harambasicluka harambasicluka changed the title Reminder to share a positive test result [EXPOSUREAPP-3551] Reminder to share a positive test result (EXPOSUREAPP-3551) Nov 9, 2020
chiljamgossow
chiljamgossow reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

chris-cwa
chris-cwa previously approved these changes Nov 10, 2020
View reviewed changes
harambasicluka
harambasicluka reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will do device testing now.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

4.8% 4.8% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 1bcf1a9 into release/1.7.x Nov 10, 2020
@harambasicluka harambasicluka deleted the feature/3551-reminder-test-result branch November 10, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chiljamgossow chiljamgossow chiljamgossow left review comments

@harambasicluka harambasicluka harambasicluka approved these changes

@chris-cwa chris-cwa chris-cwa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintainers Tag pull requests created by maintainers prio PRs to review first.

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ralfgehrer @chiljamgossow @harambasicluka @chris-cwa