This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Fix behavior of last 3 hours test mode switch (EXPOSUREAPP-3179) #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of today, due to being based of the latest server index day files. We need to get them for the latest day index file, plus 1 day.
mlenkeit
reviewed
Oct 12, 2020
Member
mlenkeit
left a comment
There was a problem hiding this comment.
What if there are less than 3 hour packages available for the given date?
Member
Just for the record: I think it's not required to fix this, as the 3 Hour mode is only used for testing, and it wouldn't work as the name suggests only between midnight and 2 am or so. I can live with that 😉 |
d4rken
commented
Oct 12, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/diagnosiskeys/download/KeyFileDownloader.kt
Show resolved
Hide resolved
BMItr
approved these changes
Oct 12, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
ralfgehrer
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the days for which the last 3 hours were fetched, was the latest day in the servers index for a country, but if a day is not complete, the day will not be visible in the index. This PR fixes this behavior by artificially adding the one additional date (
LATEST_DAY_IN_INDEX+1DAY).Testing
KeyFileDownloaderdownloads.