This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Unreliable background priority (EXPOSUREAPP-3094) #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0447a1.
… intent to open settings, also replaced in notification on first launch Signed-off-by: Kolya Opahle <[email protected]>
Signed-off-by: Kolya Opahle <[email protected]>
…corona-warn-app/cwa-app-android into fix/3094-unreliable-background-priority
harambasicluka
previously requested changes
Oct 14, 2020
Contributor
harambasicluka
left a comment
There was a problem hiding this comment.
Only checked the strings.
ralfgehrer
reviewed
Oct 15, 2020
Corona-Warn-App/src/main/res/layout/fragment_settings_background_priority.xml
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Oct 15, 2020
...arn-App/src/main/java/de/rki/coronawarnapp/ui/settings/SettingsBackgroundPriorityFragment.kt
Show resolved
Hide resolved
Signed-off-by: Kolya Opahle <[email protected]>
…corona-warn-app/cwa-app-android into fix/3094-unreliable-background-priority
Signed-off-by: Kolya Opahle <[email protected]>
…com:corona-warn-app/cwa-app-android.git into fix/3094-unreliable-background-priority
AlexanderAlferov
approved these changes
Oct 26, 2020
Contributor
AlexanderAlferov
left a comment
There was a problem hiding this comment.
Tested. Looks good!
chris-cwa
approved these changes
Oct 26, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the switch for background prioritisation from the settings fragment as they are not stable on all devices.
Im not sure if these changes are complete or if more work on ui flow is needed. Will open in draft state.