Onboarding flow refactor (EXPOSUREAPP-2995) #1337
Conversation
|
Please remove the checklist & add a milestone :) |
Yep, I will once I remove this PR from draft. |
d4rken
left a comment
There was a problem hiding this comment.
Mostly good. A bunch of small optimizations. I tried to explain but if you are still unclear about the why, please ask.
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingFragment.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingFragment.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
...Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingNotificationsFragment.kt
Outdated
Show resolved
Hide resolved
...n-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingTracingFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_onboarding_notifications.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_onboarding_privacy.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_onboarding_test.xml
Outdated
Show resolved
Hide resolved
kolyaopahle
left a comment
There was a problem hiding this comment.
one very minor nitpick otherwise lgtm
| abstract class OnboardingTracingFragmentTestModule { | ||
| @ContributesAndroidInjector | ||
| abstract fun onboardingTracingFragment(): OnboardingTracingFragment | ||
| } No newline at end of file |
There was a problem hiding this comment.
minor nitpick: Some files are missing new lines
There was a problem hiding this comment.
Ok, I'll add them
| abstract class OnboardingTestFragmentModule { | ||
| @ContributesAndroidInjector | ||
| abstract fun onboardingTestFragment(): OnboardingTestFragment | ||
| } No newline at end of file |
There was a problem hiding this comment.
minor nitpick: Some files are missing new lines
| abstract class OnboardingPrivacyTestModule { | ||
| @ContributesAndroidInjector | ||
| abstract fun onboardingPrivacyFragment(): OnboardingPrivacyFragment | ||
| } No newline at end of file |
There was a problem hiding this comment.
minor nitpick: Some files are missing new lines
| abstract class OnboardingNotificationsTestModule { | ||
| @ContributesAndroidInjector | ||
| abstract fun onboardingNotificationsFragment(): OnboardingNotificationsFragment | ||
| } No newline at end of file |
There was a problem hiding this comment.
minor nitpick: Some files are missing new lines
|
Kudos, SonarCloud Quality Gate passed!
|
Oliver-Zimmerman
left a comment
There was a problem hiding this comment.
Code looks good to me and the onboarding flow was completed successfully when I tested it. I like how you handled navigation with the OnboardingNavigationEvents. I may adopt this in my Submission flow refactor.
Description
This PR introduces the MVVM pattern with dependency injection for the onboarding flow. It also introduces the code skeleton for running instrumentation tests for each of the fragments in the onboarding flow.
How to test
Run the app and click around the onboarding flow. No behaviour changes should be noticeable. Make sure you delete the app's data before running if you've already been using the app, otherwise the onboarding flow won't show up.