Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@Oliver-Zimmerman
Copy link
Contributor

@Oliver-Zimmerman Oliver-Zimmerman commented Oct 6, 2020

Description

Added the option to, on receiving a positive result, continue without sharing any symptom details before even beginning the symptom flow via a second button.

  • Adjusted test result screen layout to include new button
  • Adjusted navigation
  • Changed logic to set symptom indication to no indication when the new button is pressed

Test

Scan QR positive QR code. You will see two buttons, one will start symptom flow and one will skip symptom flow. Once at the Other Warning screen, you should be able to submit from both flows.

Screen-Recording-20201006-161217

@Oliver-Zimmerman Oliver-Zimmerman added 1.5.0 maintainers Tag pull requests created by maintainers labels Oct 6, 2020
@harambasicluka harambasicluka changed the title [Android] Add option to skip Symptoms Screens from Test Result (EXPOSUREAPP-3075) Add option to skip Symptoms Screens from Test Result (EXPOSUREAPP-3075) Oct 6, 2020
@harambasicluka harambasicluka added this to the 1.5.0 milestone Oct 6, 2020
@Oliver-Zimmerman Oliver-Zimmerman marked this pull request as ready for review October 6, 2020 13:40
@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team October 6, 2020 13:40
harambasicluka
harambasicluka previously approved these changes Oct 6, 2020
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my device! 👍

Please name the branch the next time like we agreed on and it's written down in our internal wiki: feature/3075-skip-symptom-submission
And please also provide screenshots for a UI implementation. As in this case the flow (back and forth navigation) is relevant I would be happy to have a gif :)

Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely on my device

Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
​​​​​​​
​​​​​​​

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit ae5edbc into release/1.5.x Oct 6, 2020
@ralfgehrer ralfgehrer deleted the feature/skip-symptom-submission branch October 6, 2020 15:47
@d4rken d4rken removed the 1.5.0 label Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants