Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@SabineLoss
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue [HELP WANTED][README] Text / Translations  #332 for further information)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

Law firm provided a few minor changes to the EULA.

@SabineLoss SabineLoss requested a review from a team October 6, 2020 06:02
@ralfgehrer ralfgehrer changed the base branch from master to release/1.5.x October 6, 2020 06:15
@ralfgehrer ralfgehrer requested a review from janetback as a code owner October 6, 2020 06:15
@ralfgehrer ralfgehrer changed the base branch from release/1.5.x to release/1.6.x October 6, 2020 06:16
@ralfgehrer ralfgehrer changed the base branch from release/1.6.x to release/1.5.x October 6, 2020 06:16
@ralfgehrer ralfgehrer changed the title Fix/small typos Fix small typos (DEV) Oct 6, 2020
@ralfgehrer ralfgehrer added this to the 1.5.0 milestone Oct 6, 2020
@ralfgehrer
Copy link
Contributor

@SabineLoss originally this targeted the master branch. I suppose it should go into Release 1.5.x instead?

@ralfgehrer ralfgehrer changed the title Fix small typos (DEV) DEPRECATED - Fix small typos (DEV) Oct 6, 2020
@ralfgehrer
Copy link
Contributor

I suggest to NOT merge this PR and close it in favor of this PR:
#1318

It is properly rebased on Release 1.5.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants