Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Improve API test fragment and environment switching (DEV) #1269

Merged
merged 18 commits into from
Oct 2, 2020
Merged

Improve API test fragment and environment switching (DEV) #1269

merged 18 commits into from
Oct 2, 2020

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Oct 1, 2020 •
edited by thomasaugsten
Loading

Description

  • Align environment switching with iOS (type selection instead of a toggle)
  • Simplify build config and remove the ALTERNATIVE environment type
  • Refactored the API test fragment a bit to move some code over to the viewmodel

How to test

  • Review code+tests
  • Open the API test fragment, switch the environment, test a few other options too.

@d4rken d4rken added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers 1.5.0 labels Oct 1, 2020
@d4rken d4rken requested a review from a team October 1, 2020 07:47
d4rken added 3 commits October 1, 2020 09:50
@d4rken
Fix tests
9757702
@d4rken
Fix tests
07a5abf
@d4rken
Merge branch 'release/1.5.x' into feature/overhauled-test-fragment
035ca14 
# Conflicts:
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/environment/EnvironmentSetupTest.kt
@d4rken d4rken changed the title Improve API test fragment and environment switching Improve API test fragment and environment switching (DEV) Oct 1, 2020
d4rken added 2 commits October 1, 2020 12:46
@d4rken
Further flaky test fixes.
e37f268
@d4rken
Move the debug check for isLast3HourModeEnabled to the settings.
d7e4213 
The KeyFileDownloader.kt shouldn't be aware of that detail.
The settings are what is affected by the build flavors/modes.
mertsafter
mertsafter reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mertsafter mertsafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. One commit will be pushed by my side regarding some code cleanup of the fragment layout xml

mertsafter
mertsafter approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mertsafter mertsafter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approve from me if pipeline run is successful

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

17.0% 17.0% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit a9ae4ad into release/1.5.x Oct 2, 2020
@harambasicluka harambasicluka deleted the feature/overhauled-test-fragment branch October 2, 2020 13:08
@harambasicluka harambasicluka added this to the 1.5.0 milestone Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chris-cwa chris-cwa chris-cwa approved these changes

@mertsafter mertsafter mertsafter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@d4rken @chris-cwa @mertsafter @harambasicluka