Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@kolyaopahle
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue [HELP WANTED][README] Text / Translations  #332 for further information)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

This is currently in draft status as the decision for which text to use is not final.

This PR updates some text in the positive test result card and on the submission done thank you screen. New texts can be seen in the attached screenshots.

Screenshot_20200929-110320
Screenshot_20200929-105938

@kolyaopahle kolyaopahle added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers 1.5.0 labels Sep 29, 2020
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for PO approval.

@SabineLoss
Copy link
Contributor

UA reviewed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harambasicluka harambasicluka marked this pull request as ready for review September 29, 2020 13:51
@harambasicluka harambasicluka requested a review from a team September 29, 2020 13:51
@harambasicluka harambasicluka merged commit a301cbe into release/1.5.x Sep 29, 2020
@harambasicluka harambasicluka deleted the feature/2693-text-enhancement branch September 29, 2020 13:51
@harambasicluka harambasicluka added this to the 1.5.0 milestone Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers ui Issue related to UI aspects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants