Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Force specific log tags in a few instances #1249

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Force specific log tags in a few instances #1249

merged 5 commits into from
Sep 29, 2020

Conversation

@d4rken
Copy link
Member

@d4rken d4rken commented Sep 28, 2020

Force specific logtags as automatic tag generation does not produce unique tags here (i.e. "BaseContinuationImpl").
Noticed this while reviewing some of the log files testers provided.
Mostly affects lamdas, often in relation to coroutines.
Otherwise we have a few cases where it doesn't log the obvious source:

1600701521373  V/BaseContinuationImpl: Keys were not retrieved today false
1600701521374  V/BaseContinuationImpl: Network is enabled true
1600701521374  V/BaseContinuationImpl: Background jobs are enabled true
1600701521375  D/BaseContinuationImpl: 1440c7ee-03ac-460e-8fc4-0c207b9a7458 - STATE CHANGE: INIT
1600701521409  D/BaseContinuationImpl: f43b34b0-2b43-4439-a363-6d3013be4a09 - STATE CHANGE: CHECK_TRACING

@d4rken
Force specific logtags as automatic tag generation does not produce u…
5166d58 
…nique tags here (i.e. "BaseContinuationImpl").
@d4rken d4rken added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers 1.5.0 labels Sep 28, 2020
@d4rken d4rken requested a review from a team September 28, 2020 16:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

7.7% 7.7% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit f5e6b1c into release/1.5.x Sep 29, 2020
@harambasicluka harambasicluka deleted the fix/logging-tags branch September 29, 2020 14:10
@harambasicluka harambasicluka added this to the 1.5.0 milestone Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@Oliver-Zimmerman Oliver-Zimmerman Oliver-Zimmerman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@d4rken @ralfgehrer @Oliver-Zimmerman @harambasicluka