This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Submission logic for interop (EXPOSUREAPP-2737) #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies. TODO: Unit tests, pull supportedCountries from AppConfig (waiting for #1213)
This would break daggers annotation processing as the class could not be resolved.
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/service/applicationconfiguration/ApplicationConfigurationServiceTest.kt
…the submission transaction. (Previously wasn't implemented yet, now it's merged)
mlenkeit
reviewed
Sep 29, 2020
...na-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/SubmitDiagnosisKeysTransaction.kt
Outdated
Show resolved
Hide resolved
d4rken
commented
Sep 29, 2020
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/http/ServiceFactory.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/security/VerificationKeys.kt
…try list is empty/not supplied.
chris-cwa
reviewed
Sep 30, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/submission/server/SubmissionServer.kt
Show resolved
Hide resolved
chris-cwa
reviewed
Sep 30, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/PaddingTool.kt
Outdated
Show resolved
Hide resolved
chris-cwa
reviewed
Sep 30, 2020
mlenkeit
reviewed
Sep 30, 2020
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/appconfig/AppConfigProviderTest.kt
Outdated
Show resolved
Hide resolved
The UI requires the list to be empty, if it is empty in the config. I've moved the fallback country insertion into the transaction.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds submission logic for interop, adding
consentToFederationandvisistedCountriesfrom the app config.To successfully test our logic, additional refactoring was necessary to further rid ourselves of the singletons. This includes the verification, submission and playbook logic which are now separated and injected.
How to test
Draft TODO